github: fix build push build arg format #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix is ported from #2276 |
xenowits
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2482 +/- ##
==========================================
+ Coverage 53.53% 53.56% +0.02%
==========================================
Files 198 198
Lines 26757 26757
==========================================
+ Hits 14325 14332 +7
+ Misses 10649 10642 -7
Partials 1783 1783 ☔ View full report in Codecov by Sentry. |
corverroos
approved these changes
Jul 28, 2023
xenowits
added
the
merge when ready
xenowits
added a commit
that referenced
this pull request
Jul 28, 2023
Fixes the github action "build-push-deploys" `build-args` parameter. It is a [list parameter that is new line delimited](https://github.com/docker/build-push-action#inputs). Also remove `-a` build arg since it isn't required. Make it explicit that `GO_BUILD_FLAG` only supports a single flag. This ports the fix from `main-v0.16` release branch to main. category: misc ticket: #2270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the github action "build-push-deploys"
build-argsparameter. It is a list parameter that is new line delimited.Also remove
-abuild arg since it isn't required. Make it explicit thatGO_BUILD_FLAGonly supports a single flag.This ports the fix from
main-v0.16release branch to main.category: misc
ticket: #2270